Add Plex library count sensors#48339
Merged
frenck merged 7 commits intohome-assistant:devfrom Mar 31, 2021
Merged
Conversation
probot-home-assistant
Bot
added
has-tests
integration: plex
new-feature
by-code-owner
labels
frenck
reviewed
Mar 26, 2021
8 tasks
bdraco
reviewed
Mar 31, 2021
bdraco
reviewed
Mar 31, 2021
bdraco
approved these changes
Mar 31, 2021
Member
bdraco
left a comment
bdraco
left a comment
There was a problem hiding this comment.
LGTM. Two small comments above
bdraco
approved these changes
Mar 31, 2021
frenck
approved these changes
Mar 31, 2021
| try: | ||
| await self.hass.async_add_executor_job(self._update_state_and_attrs) | ||
| except NotFound: | ||
| self._state = STATE_UNAVAILABLE |
Member
There was a problem hiding this comment.
We don't set unavailable state directly. We modify the return value of the available property.
Contributor
Author
There was a problem hiding this comment.
Good catch, I'll fix. 👍
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds a new sensor for each Plex library showing the total number of items it contains. Also shows count attributes for special cases, such as shows & seasons for TV and artist & albums for music.
Associates all sensors with the existing Plex server device and gives that device a more appropriate name.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: